From 3201b843a8407d2c27971b6d33b7044f82f23c49 Mon Sep 17 00:00:00 2001 From: Journey <52627267+chengazhen@users.noreply.github.com> Date: Thu, 19 Dec 2024 09:34:42 +0800 Subject: [PATCH] fix: resolve eslint errors as well as TS type errors (#5172) * fix: remove TypeScript error suppression for missing types in Vue ESLint config * fix: enhance application configuration with CSS options type support --- internal/lint-configs/eslint-config/src/configs/vue.ts | 1 - internal/vite-config/src/config/application.ts | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/internal/lint-configs/eslint-config/src/configs/vue.ts b/internal/lint-configs/eslint-config/src/configs/vue.ts index 27cc3cf2..d1c6521c 100644 --- a/internal/lint-configs/eslint-config/src/configs/vue.ts +++ b/internal/lint-configs/eslint-config/src/configs/vue.ts @@ -4,7 +4,6 @@ import { interopDefault } from '../util'; export async function vue(): Promise { const [pluginVue, parserVue, parserTs] = await Promise.all([ - // @ts-expect-error missing types interopDefault(import('eslint-plugin-vue')), interopDefault(import('vue-eslint-parser')), // @ts-expect-error missing types diff --git a/internal/vite-config/src/config/application.ts b/internal/vite-config/src/config/application.ts index f2276094..f9808cc7 100644 --- a/internal/vite-config/src/config/application.ts +++ b/internal/vite-config/src/config/application.ts @@ -1,4 +1,4 @@ -import type { UserConfig } from 'vite'; +import type { CSSOptions, UserConfig } from 'vite'; import type { DefineApplicationOptions } from '../typing'; @@ -100,7 +100,7 @@ function defineApplicationConfig(userConfigPromise?: DefineApplicationOptions) { }); } -function createCssOptions(injectGlobalScss = true) { +function createCssOptions(injectGlobalScss = true): CSSOptions { const root = findMonorepoRoot(); return { preprocessorOptions: injectGlobalScss